Skip to content

Commit

Permalink
rtc: cmos: Refactor code by using the new dmi_get_bios_year() helper
Browse files Browse the repository at this point in the history
Refactor code by using the new dmi_get_bios_year() helper instead of
open coding its functionality. This also makes logic slightly clearer.

No changes intended.

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Guilherme G. Piccoli <gpiccoli@canonical.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20200123131437.28157-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
  • Loading branch information
Andy Shevchenko authored and Alexandre Belloni committed Jan 25, 2020
1 parent 5848ad2 commit 604c521
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/rtc/rtc-cmos.c
Original file line number Diff line number Diff line change
Expand Up @@ -1197,8 +1197,6 @@ static void rtc_wake_off(struct device *dev)
/* Enable use_acpi_alarm mode for Intel platforms no earlier than 2015 */
static void use_acpi_alarm_quirks(void)
{
int year;

if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
return;

Expand All @@ -1208,8 +1206,10 @@ static void use_acpi_alarm_quirks(void)
if (!is_hpet_enabled())
return;

if (dmi_get_date(DMI_BIOS_DATE, &year, NULL, NULL) && year >= 2015)
use_acpi_alarm = true;
if (dmi_get_bios_year() < 2015)
return;

use_acpi_alarm = true;
}
#else
static inline void use_acpi_alarm_quirks(void) { }
Expand Down

0 comments on commit 604c521

Please sign in to comment.