Skip to content

Commit

Permalink
mmc: usdhi6rol0: Fix a resource leak in the error handling path of th…
Browse files Browse the repository at this point in the history
…e probe

A call to 'ausdhi6_dma_release()' to undo a previous call to
'usdhi6_dma_request()' is missing in the error handling path of the probe
function.

It is already present in the remove function.

Fixes: 75fa9ea ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20201217210922.165340-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
  • Loading branch information
Christophe JAILLET authored and Ulf Hansson committed Feb 1, 2021
1 parent c9c256a commit 6052b3c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/mmc/host/usdhi6rol0.c
Original file line number Diff line number Diff line change
Expand Up @@ -1858,10 +1858,12 @@ static int usdhi6_probe(struct platform_device *pdev)

ret = mmc_add_host(mmc);
if (ret < 0)
goto e_clk_off;
goto e_release_dma;

return 0;

e_release_dma:
usdhi6_dma_release(host);
e_clk_off:
clk_disable_unprepare(host->clk);
e_free_mmc:
Expand Down

0 comments on commit 6052b3c

Please sign in to comment.