Skip to content

Commit

Permalink
net: Use hton[sl]() instead of __constant_hton[sl]() where applicable
Browse files Browse the repository at this point in the history
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Arnaldo Carvalho de Melo authored and David S. Miller committed Sep 21, 2008
1 parent a574420 commit 6067804
Showing 11 changed files with 35 additions and 35 deletions.
2 changes: 1 addition & 1 deletion net/8021q/vlan_dev.c
Original file line number Diff line number Diff line change
@@ -48,7 +48,7 @@ static int vlan_dev_rebuild_header(struct sk_buff *skb)

switch (veth->h_vlan_encapsulated_proto) {
#ifdef CONFIG_INET
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):

/* TODO: Confirm this will work with VLAN headers... */
return arp_find(veth->h_dest, skb);
8 changes: 4 additions & 4 deletions net/atm/br2684.c
Original file line number Diff line number Diff line change
@@ -375,11 +375,11 @@ static void br2684_push(struct atm_vcc *atmvcc, struct sk_buff *skb)
if (memcmp
(skb->data + 6, ethertype_ipv6,
sizeof(ethertype_ipv6)) == 0)
skb->protocol = __constant_htons(ETH_P_IPV6);
skb->protocol = htons(ETH_P_IPV6);
else if (memcmp
(skb->data + 6, ethertype_ipv4,
sizeof(ethertype_ipv4)) == 0)
skb->protocol = __constant_htons(ETH_P_IP);
skb->protocol = htons(ETH_P_IP);
else
goto error;
skb_pull(skb, sizeof(llc_oui_ipv4));
@@ -404,9 +404,9 @@ static void br2684_push(struct atm_vcc *atmvcc, struct sk_buff *skb)
skb_reset_network_header(skb);
iph = ip_hdr(skb);
if (iph->version == 4)
skb->protocol = __constant_htons(ETH_P_IP);
skb->protocol = htons(ETH_P_IP);
else if (iph->version == 6)
skb->protocol = __constant_htons(ETH_P_IPV6);
skb->protocol = htons(ETH_P_IPV6);
else
goto error;
skb->pkt_type = PACKET_HOST;
4 changes: 2 additions & 2 deletions net/core/dev.c
Original file line number Diff line number Diff line change
@@ -1675,13 +1675,13 @@ static u16 simple_tx_hash(struct net_device *dev, struct sk_buff *skb)
}

switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
ip_proto = ip_hdr(skb)->protocol;
addr1 = ip_hdr(skb)->saddr;
addr2 = ip_hdr(skb)->daddr;
ihl = ip_hdr(skb)->ihl;
break;
case __constant_htons(ETH_P_IPV6):
case htons(ETH_P_IPV6):
ip_proto = ipv6_hdr(skb)->nexthdr;
addr1 = ipv6_hdr(skb)->saddr.s6_addr32[3];
addr2 = ipv6_hdr(skb)->daddr.s6_addr32[3];
2 changes: 1 addition & 1 deletion net/ethernet/eth.c
Original file line number Diff line number Diff line change
@@ -129,7 +129,7 @@ int eth_rebuild_header(struct sk_buff *skb)

switch (eth->h_proto) {
#ifdef CONFIG_INET
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
return arp_find(eth->h_dest, skb);
#endif
default:
4 changes: 2 additions & 2 deletions net/ipv4/ipvs/ip_vs_core.c
Original file line number Diff line number Diff line change
@@ -938,7 +938,7 @@ ip_vs_out(unsigned int hooknum, struct sk_buff *skb,

EnterFunction(11);

af = (skb->protocol == __constant_htons(ETH_P_IP)) ? AF_INET : AF_INET6;
af = (skb->protocol == htons(ETH_P_IP)) ? AF_INET : AF_INET6;

if (skb->ipvs_property)
return NF_ACCEPT;
@@ -1258,7 +1258,7 @@ ip_vs_in(unsigned int hooknum, struct sk_buff *skb,
struct ip_vs_conn *cp;
int ret, restart, af;

af = (skb->protocol == __constant_htons(ETH_P_IP)) ? AF_INET : AF_INET6;
af = (skb->protocol == htons(ETH_P_IP)) ? AF_INET : AF_INET6;

ip_vs_fill_iphdr(af, skb_network_header(skb), &iph);

4 changes: 2 additions & 2 deletions net/ipv6/ip6_tunnel.c
Original file line number Diff line number Diff line change
@@ -1050,10 +1050,10 @@ ip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev)
}

switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
ret = ip4ip6_tnl_xmit(skb, dev);
break;
case __constant_htons(ETH_P_IPV6):
case htons(ETH_P_IPV6):
ret = ip6ip6_tnl_xmit(skb, dev);
break;
default:
2 changes: 1 addition & 1 deletion net/mac80211/wme.c
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ static unsigned int classify_1d(struct sk_buff *skb)
return skb->priority - 256;

switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
dscp = ip_hdr(skb)->tos & 0xfc;
break;

28 changes: 14 additions & 14 deletions net/sched/cls_flow.c
Original file line number Diff line number Diff line change
@@ -67,9 +67,9 @@ static inline u32 addr_fold(void *addr)
static u32 flow_get_src(const struct sk_buff *skb)
{
switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
return ntohl(ip_hdr(skb)->saddr);
case __constant_htons(ETH_P_IPV6):
case htons(ETH_P_IPV6):
return ntohl(ipv6_hdr(skb)->saddr.s6_addr32[3]);
default:
return addr_fold(skb->sk);
@@ -79,9 +79,9 @@ static u32 flow_get_src(const struct sk_buff *skb)
static u32 flow_get_dst(const struct sk_buff *skb)
{
switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
return ntohl(ip_hdr(skb)->daddr);
case __constant_htons(ETH_P_IPV6):
case htons(ETH_P_IPV6):
return ntohl(ipv6_hdr(skb)->daddr.s6_addr32[3]);
default:
return addr_fold(skb->dst) ^ (__force u16)skb->protocol;
@@ -91,9 +91,9 @@ static u32 flow_get_dst(const struct sk_buff *skb)
static u32 flow_get_proto(const struct sk_buff *skb)
{
switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
return ip_hdr(skb)->protocol;
case __constant_htons(ETH_P_IPV6):
case htons(ETH_P_IPV6):
return ipv6_hdr(skb)->nexthdr;
default:
return 0;
@@ -120,15 +120,15 @@ static u32 flow_get_proto_src(const struct sk_buff *skb)
u32 res = 0;

switch (skb->protocol) {
case __constant_htons(ETH_P_IP): {
case htons(ETH_P_IP): {
struct iphdr *iph = ip_hdr(skb);

if (!(iph->frag_off&htons(IP_MF|IP_OFFSET)) &&
has_ports(iph->protocol))
res = ntohs(*(__be16 *)((void *)iph + iph->ihl * 4));
break;
}
case __constant_htons(ETH_P_IPV6): {
case htons(ETH_P_IPV6): {
struct ipv6hdr *iph = ipv6_hdr(skb);

if (has_ports(iph->nexthdr))
@@ -147,15 +147,15 @@ static u32 flow_get_proto_dst(const struct sk_buff *skb)
u32 res = 0;

switch (skb->protocol) {
case __constant_htons(ETH_P_IP): {
case htons(ETH_P_IP): {
struct iphdr *iph = ip_hdr(skb);

if (!(iph->frag_off&htons(IP_MF|IP_OFFSET)) &&
has_ports(iph->protocol))
res = ntohs(*(__be16 *)((void *)iph + iph->ihl * 4 + 2));
break;
}
case __constant_htons(ETH_P_IPV6): {
case htons(ETH_P_IPV6): {
struct ipv6hdr *iph = ipv6_hdr(skb);

if (has_ports(iph->nexthdr))
@@ -213,9 +213,9 @@ static u32 flow_get_nfct(const struct sk_buff *skb)
static u32 flow_get_nfct_src(const struct sk_buff *skb)
{
switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
return ntohl(CTTUPLE(skb, src.u3.ip));
case __constant_htons(ETH_P_IPV6):
case htons(ETH_P_IPV6):
return ntohl(CTTUPLE(skb, src.u3.ip6[3]));
}
fallback:
@@ -225,9 +225,9 @@ static u32 flow_get_nfct_src(const struct sk_buff *skb)
static u32 flow_get_nfct_dst(const struct sk_buff *skb)
{
switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
return ntohl(CTTUPLE(skb, dst.u3.ip));
case __constant_htons(ETH_P_IPV6):
case htons(ETH_P_IPV6):
return ntohl(CTTUPLE(skb, dst.u3.ip6[3]));
}
fallback:
8 changes: 4 additions & 4 deletions net/sched/sch_dsmark.c
Original file line number Diff line number Diff line change
@@ -202,15 +202,15 @@ static int dsmark_enqueue(struct sk_buff *skb, struct Qdisc *sch)

if (p->set_tc_index) {
switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
if (skb_cow_head(skb, sizeof(struct iphdr)))
goto drop;

skb->tc_index = ipv4_get_dsfield(ip_hdr(skb))
& ~INET_ECN_MASK;
break;

case __constant_htons(ETH_P_IPV6):
case htons(ETH_P_IPV6):
if (skb_cow_head(skb, sizeof(struct ipv6hdr)))
goto drop;

@@ -289,11 +289,11 @@ static struct sk_buff *dsmark_dequeue(struct Qdisc *sch)
pr_debug("index %d->%d\n", skb->tc_index, index);

switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
ipv4_change_dsfield(ip_hdr(skb), p->mask[index],
p->value[index]);
break;
case __constant_htons(ETH_P_IPV6):
case htons(ETH_P_IPV6):
ipv6_change_dsfield(ipv6_hdr(skb), p->mask[index],
p->value[index]);
break;
4 changes: 2 additions & 2 deletions net/sched/sch_sfq.c
Original file line number Diff line number Diff line change
@@ -119,7 +119,7 @@ static unsigned sfq_hash(struct sfq_sched_data *q, struct sk_buff *skb)
u32 h, h2;

switch (skb->protocol) {
case __constant_htons(ETH_P_IP):
case htons(ETH_P_IP):
{
const struct iphdr *iph = ip_hdr(skb);
h = iph->daddr;
@@ -134,7 +134,7 @@ static unsigned sfq_hash(struct sfq_sched_data *q, struct sk_buff *skb)
h2 ^= *(((u32*)iph) + iph->ihl);
break;
}
case __constant_htons(ETH_P_IPV6):
case htons(ETH_P_IPV6):
{
struct ipv6hdr *iph = ipv6_hdr(skb);
h = iph->daddr.s6_addr32[3];
4 changes: 2 additions & 2 deletions net/sunrpc/xprtrdma/rpc_rdma.c
Original file line number Diff line number Diff line change
@@ -769,7 +769,7 @@ rpcrdma_reply_handler(struct rpcrdma_rep *rep)
/* check for expected message types */
/* The order of some of these tests is important. */
switch (headerp->rm_type) {
case __constant_htonl(RDMA_MSG):
case htonl(RDMA_MSG):
/* never expect read chunks */
/* never expect reply chunks (two ways to check) */
/* never expect write chunks without having offered RDMA */
@@ -802,7 +802,7 @@ rpcrdma_reply_handler(struct rpcrdma_rep *rep)
rpcrdma_inline_fixup(rqst, (char *)iptr, rep->rr_len);
break;

case __constant_htonl(RDMA_NOMSG):
case htonl(RDMA_NOMSG):
/* never expect read or write chunks, always reply chunks */
if (headerp->rm_body.rm_chunks[0] != xdr_zero ||
headerp->rm_body.rm_chunks[1] != xdr_zero ||

0 comments on commit 6067804

Please sign in to comment.