Skip to content

Commit

Permalink
iommu/amd: Initialize devid variable before using it
Browse files Browse the repository at this point in the history
Commit 2a0cb4e ("iommu/amd: Add new map for storing IVHD dev entry
type HID") added a call to DUMP_printk in init_iommu_from_acpi() which
used the value of devid before this variable was initialized.

Fixes: 2a0cb4e ('iommu/amd: Add new map for storing IVHD dev entry type HID')
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
Nicolas Iooss authored and Joerg Roedel committed Jun 27, 2016
1 parent 3bd4f91 commit 6082ee7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/iommu/amd_iommu_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -1107,13 +1107,13 @@ static int __init init_iommu_from_acpi(struct amd_iommu *iommu,
break;
}

devid = e->devid;
DUMP_printk(" DEV_ACPI_HID(%s[%s])\t\tdevid: %02x:%02x.%x\n",
hid, uid,
PCI_BUS_NUM(devid),
PCI_SLOT(devid),
PCI_FUNC(devid));

devid = e->devid;
flags = e->flags;

ret = add_acpi_hid_device(hid, uid, &devid, false);
Expand Down

0 comments on commit 6082ee7

Please sign in to comment.