Skip to content

Commit

Permalink
firewire: nosy: char device is not seekable
Browse files Browse the repository at this point in the history
Amend .open handler accordingly and remove the .llseek handler.
.llseek = NULL means no_llseek (return error) since commit 776c163.

The only client that uses this interface is nosy-dump in linux/tools/firewire
and it knows not to seek in this char dev.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Stefan Richter committed Dec 12, 2010
1 parent 9993e0f commit 60a74a6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/firewire/nosy.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ nosy_open(struct inode *inode, struct file *file)

file->private_data = client;

return 0;
return nonseekable_open(inode, file);
fail:
kfree(client);
lynx_put(lynx);
Expand Down Expand Up @@ -405,7 +405,6 @@ static const struct file_operations nosy_ops = {
.poll = nosy_poll,
.open = nosy_open,
.release = nosy_release,
.llseek = noop_llseek,
};

#define PHY_PACKET_SIZE 12 /* 1 payload, 1 inverse, 1 ack = 3 quadlets */
Expand Down

0 comments on commit 60a74a6

Please sign in to comment.