Skip to content

Commit

Permalink
percpu: fix spurious alignment WARN in legacy SMP percpu allocator
Browse files Browse the repository at this point in the history
Impact: remove spurious WARN on legacy SMP percpu allocator

Commit f2a8205 incorrectly added too
tight WARN_ON_ONCE() on alignments for UP and legacy SMP percpu
allocator.  Commit e317603 fixed it
for UP but legacy SMP allocator was forgotten.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Sachin P. Sant <sachinp@in.ibm.com>
  • Loading branch information
Tejun Heo committed Mar 11, 2009
1 parent 66c3a75 commit 60db564
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mm/allocpercpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ void *__alloc_percpu(size_t size, size_t align)
* on it. Larger alignment should only be used for module
* percpu sections on SMP for which this path isn't used.
*/
WARN_ON_ONCE(align > __alignof__(unsigned long long));
WARN_ON_ONCE(align > SMP_CACHE_BYTES);

if (unlikely(!pdata))
return NULL;
Expand Down

0 comments on commit 60db564

Please sign in to comment.