Skip to content

Commit

Permalink
9p: client: remove unused code and any reference to "cancelled" function
Browse files Browse the repository at this point in the history
This patch reverts commit

80b4526

which was implementing a 'cancelled' functionality to notify that
a cancelled request will not be replied.

This implementation was not used anywhere and therefore removed.

Signed-off-by: Andi Shyti <andi@etezian.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Andi Shyti authored and David S. Miller committed Jul 30, 2013
1 parent 4ce1fd6 commit 60ff779
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
3 changes: 0 additions & 3 deletions include/net/9p/transport.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@
* @close: member function to discard a connection on this transport
* @request: member function to issue a request to the transport
* @cancel: member function to cancel a request (if it hasn't been sent)
* @cancelled: member function to notify that a cancelled request will not
* not receive a reply
*
* This is the basic API for a transport module which is registered by the
* transport module with the 9P core network module and used by the client
Expand All @@ -60,7 +58,6 @@ struct p9_trans_module {
void (*close) (struct p9_client *);
int (*request) (struct p9_client *, struct p9_req_t *req);
int (*cancel) (struct p9_client *, struct p9_req_t *req);
int (*cancelled)(struct p9_client *, struct p9_req_t *req);
int (*zc_request)(struct p9_client *, struct p9_req_t *,
char *, char *, int , int, int, int);
};
Expand Down
9 changes: 2 additions & 7 deletions net/9p/client.c
Original file line number Diff line number Diff line change
Expand Up @@ -658,17 +658,12 @@ static int p9_client_flush(struct p9_client *c, struct p9_req_t *oldreq)

/*
* if we haven't received a response for oldreq,
* remove it from the list, and notify the transport
* layer that the reply will never arrive.
* remove it from the list
*/
spin_lock(&c->lock);
if (oldreq->status == REQ_STATUS_FLSH) {
spin_lock(&c->lock);
list_del(&oldreq->req_list);
spin_unlock(&c->lock);
if (c->trans_mod->cancelled)
c->trans_mod->cancelled(c, req);
} else {
spin_unlock(&c->lock);
}

p9_free_req(c, req);
Expand Down

0 comments on commit 60ff779

Please sign in to comment.