Skip to content

Commit

Permalink
fs/ceph/xattr.c: Use kmemdup
Browse files Browse the repository at this point in the history
Convert a sequence of kmalloc and memcpy to use kmemdup.

The semantic patch that performs this transformation is:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression a,flag,len;
expression arg,e1,e2;
statement S;
@@

  a =
-  \(kmalloc\|kzalloc\)(len,flag)
+  kmemdup(arg,len,flag)
  <... when != a
  if (a == NULL || ...) S
  ...>
- memcpy(a,arg,len+1);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Sage Weil <sage@newdream.net>
  • Loading branch information
Julia Lawall authored and Sage Weil committed Oct 20, 2010
1 parent 85b5aaa commit 61413c2
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/ceph/xattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -716,10 +716,9 @@ int ceph_setxattr(struct dentry *dentry, const char *name,

/* preallocate memory for xattr name, value, index node */
err = -ENOMEM;
newname = kmalloc(name_len + 1, GFP_NOFS);
newname = kmemdup(name, name_len + 1, GFP_NOFS);
if (!newname)
goto out;
memcpy(newname, name, name_len + 1);

if (val_len) {
newval = kmalloc(val_len + 1, GFP_NOFS);
Expand Down

0 comments on commit 61413c2

Please sign in to comment.