Skip to content

Commit

Permalink
clk: mvebu: armada-37xx-periph: Fix wrong return value in get_parent
Browse files Browse the repository at this point in the history
The return value of the get_parent operation is a u8, whereas a -EINVAL
was returned. This wrong value was return if the value was bigger that
the number of parent but this case was already handled by the core.

So we can just remove this chunk of code to fix the issue.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 9818a7a ("clk: mvebu: armada-37xx-periph: prepare cpu clk to
be used with DVFS")
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
  • Loading branch information
Gregory CLEMENT authored and Stephen Boyd committed Jul 25, 2018
1 parent ce397d2 commit 616bf80
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/clk/mvebu/armada-37xx-periph.c
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,6 @@ static u8 clk_pm_cpu_get_parent(struct clk_hw *hw)
val &= pm_cpu->mask_mux;
}

if (val >= num_parents)
return -EINVAL;

return val;
}

Expand Down

0 comments on commit 616bf80

Please sign in to comment.