Skip to content

Commit

Permalink
wifi: rtw89: Fix some error handling path in rtw89_wow_enable()
Browse files Browse the repository at this point in the history
'ret' is not updated after several function calls in rtw89_wow_enable().
This prevent error handling from working.

Add the missing assignments.

Fixes: 19e28c7 ("wifi: rtw89: add WoWLAN function support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/32320176eeff1c635baeea25ef0e87d116859e65.1668354083.git.christophe.jaillet@wanadoo.fr
  • Loading branch information
Christophe JAILLET authored and Kalle Valo committed Nov 16, 2022
1 parent 89e7064 commit 61ec34d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/wireless/realtek/rtw89/wow.c
Original file line number Diff line number Diff line change
Expand Up @@ -744,21 +744,21 @@ static int rtw89_wow_enable(struct rtw89_dev *rtwdev)
goto out;
}

rtw89_wow_swap_fw(rtwdev, true);
ret = rtw89_wow_swap_fw(rtwdev, true);
if (ret) {
rtw89_err(rtwdev, "wow: failed to swap to wow fw\n");
goto out;
}

rtw89_wow_fw_start(rtwdev);
ret = rtw89_wow_fw_start(rtwdev);
if (ret) {
rtw89_err(rtwdev, "wow: failed to let wow fw start\n");
goto out;
}

rtw89_wow_enter_lps(rtwdev);

rtw89_wow_enable_trx_post(rtwdev);
ret = rtw89_wow_enable_trx_post(rtwdev);
if (ret) {
rtw89_err(rtwdev, "wow: failed to enable trx_post\n");
goto out;
Expand Down

0 comments on commit 61ec34d

Please sign in to comment.