Skip to content

Commit

Permalink
ALSA: au88x0: fix incorrect left shift
Browse files Browse the repository at this point in the history
vortex_wt_setdsout performs bit-negation on the bit position (wt&0x1f)
rather than on the resulting bitmask.  This code is never actually
invoked (vortex_wt_setdsout is always called with en=1), so this does
not currently cause any problem, and this patch is simply cleanup.

Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Nickolai Zeldovich authored and Takashi Iwai committed Jan 7, 2013
1 parent dc30a43 commit 61ed1dc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/pci/au88x0/au88x0_synth.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ static void vortex_wt_setdsout(vortex_t * vortex, u32 wt, int en)
if (en)
temp |= (1 << (wt & 0x1f));
else
temp &= (1 << ~(wt & 0x1f));
temp &= ~(1 << (wt & 0x1f));
hwwrite(vortex->mmio, WT_DSREG((wt >= 0x20) ? 1 : 0), temp);
}

Expand Down

0 comments on commit 61ed1dc

Please sign in to comment.