Skip to content

Commit

Permalink
pinctrl: qcom: sm8350: Correct UFS and SDC offsets
Browse files Browse the repository at this point in the history
The downstream TLMM binding covers a group of TLMM-related hardware
blocks, but the upstream binding only captures the particular block
related to controlling the TLMM pins from an OS. In the translation of
the driver from downstream, the offset of 0x100000 was lost for the UFS
and SDC pingroups.

Fixes: d5d348a ("pinctrl: qcom: Add SM8350 pinctrl driver")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Link: https://lore.kernel.org/r/20211104170835.1993686-1-bjorn.andersson@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Bjorn Andersson authored and Linus Walleij committed Nov 16, 2021
1 parent 293083f commit 62209e8
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/pinctrl/qcom/pinctrl-sm8350.c
Original file line number Diff line number Diff line change
Expand Up @@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
[200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
[201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
[202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
[203] = UFS_RESET(ufs_reset, 0x1d8000),
[204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
[205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
[206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
[203] = UFS_RESET(ufs_reset, 0xd8000),
[204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
[205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
[206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),
};

static const struct msm_gpio_wakeirq_map sm8350_pdc_map[] = {
Expand Down

0 comments on commit 62209e8

Please sign in to comment.