Skip to content

Commit

Permalink
workqueue/hotplug: remove the workaround in rebind_workers()
Browse files Browse the repository at this point in the history
Since the cpu/hotplug refactoring, DOWN_FAILED is never called without
preceding DOWN_PREPARE making the workaround unnecessary.  Remove it.

Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Lai Jiangshan authored and Tejun Heo committed Dec 4, 2017
1 parent e8b3f8d commit 62408c1
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions kernel/workqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -4589,16 +4589,6 @@ static void rebind_workers(struct worker_pool *pool)

spin_lock_irq(&pool->lock);

/*
* XXX: CPU hotplug notifiers are weird and can call DOWN_FAILED
* w/o preceding DOWN_PREPARE. Work around it. CPU hotplug is
* being reworked and this can go away in time.
*/
if (!(pool->flags & POOL_DISASSOCIATED)) {
spin_unlock_irq(&pool->lock);
return;
}

pool->flags &= ~POOL_DISASSOCIATED;

for_each_pool_worker(worker, pool) {
Expand Down

0 comments on commit 62408c1

Please sign in to comment.