Skip to content

Commit

Permalink
pkt_sched: Simplify dev_requeue_skb and dequeue_skb
Browse files Browse the repository at this point in the history
qdisc->requeue was planned to universally replace all requeuing code,
but at the top level we never requeue more than one skb, so qdisc->
gso_skb is enough for this. qdisc->requeue would be used on the lower
levels only for one level deep requeuing (like in sch_hfsc) after
finishing all the changes.

Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jarek Poplawski authored and David S. Miller committed Oct 6, 2008
1 parent 554794d commit 6252352
Showing 1 changed file with 5 additions and 16 deletions.
21 changes: 5 additions & 16 deletions net/sched/sch_generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,37 +44,26 @@ static inline int qdisc_qlen(struct Qdisc *q)

static inline int dev_requeue_skb(struct sk_buff *skb, struct Qdisc *q)
{
if (unlikely(skb->next))
q->gso_skb = skb;
else
__skb_queue_head(&q->requeue, skb);

q->gso_skb = skb;
__netif_schedule(q);

return 0;
}

static inline struct sk_buff *dequeue_skb(struct Qdisc *q)
{
struct sk_buff *skb = q->gso_skb;

if (!skb)
skb = skb_peek(&q->requeue);

if (unlikely(skb)) {
struct net_device *dev = qdisc_dev(q);
struct netdev_queue *txq;

/* check the reason of requeuing without tx lock first */
txq = netdev_get_tx_queue(dev, skb_get_queue_mapping(skb));
if (!netif_tx_queue_stopped(txq) &&
!netif_tx_queue_frozen(txq)) {
if (q->gso_skb)
q->gso_skb = NULL;
else
__skb_unlink(skb, &q->requeue);
} else {
if (!netif_tx_queue_stopped(txq) && !netif_tx_queue_frozen(txq))
q->gso_skb = NULL;
else
skb = NULL;
}
} else {
skb = q->dequeue(q);
}
Expand Down

0 comments on commit 6252352

Please sign in to comment.