Skip to content

Commit

Permalink
staging: mt7621-pinctrl: make use of pinctrl_utils_reserve_map
Browse files Browse the repository at this point in the history
Function rt2880_pinctrl_dt_node_to_map was using 'kzalloc' to
reserve map memory. There is a 'pinctrl_utils_reserve_map' to
do this function. Just use it.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sergio Paracuellos authored and Greg Kroah-Hartman committed Jul 6, 2018
1 parent 4a1cf86 commit 62b6215
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ static int rt2880_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrldev,
struct pinctrl_map **map,
unsigned int *num_maps)
{
struct rt2880_priv *p = pinctrl_dev_get_drvdata(pctrldev);
int ret;
int max_maps = 0;
unsigned int reserved_maps = 0;
struct pinctrl_map *tmp;
struct device_node *np;

Expand All @@ -127,9 +130,12 @@ static int rt2880_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrldev,
if (!max_maps)
return max_maps;

*map = kcalloc(max_maps, sizeof(struct pinctrl_map), GFP_KERNEL);
if (!*map)
return -ENOMEM;
ret = pinctrl_utils_reserve_map(pctrldev, map, &reserved_maps,
num_maps, max_maps);
if (ret) {
dev_err(p->dev, "can't reserve map: %d\n", ret);
return ret;
}

tmp = *map;

Expand Down

0 comments on commit 62b6215

Please sign in to comment.