Skip to content

Commit

Permalink
cxl: Move cxl_afu_get / cxl_afu_put to base
Browse files Browse the repository at this point in the history
The Mellanox CX4 uses a model where the AFU is one physical function of
the device, and is used by other peer physical functions of the same
device. This will require those other devices to grab a reference on the
AFU when they are initialised to make sure that it does not go away
during their lifetime.

Move the AFU refcount functions to base.c so they can be called from
the PHB code.

Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Reviewed-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Ian Munsie authored and Michael Ellerman committed Jul 14, 2016
1 parent 48b3adf commit 62ccf2d
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 12 deletions.
13 changes: 13 additions & 0 deletions drivers/misc/cxl/base.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,19 @@ static inline void cxl_calls_put(struct cxl_calls *calls) { }

#endif /* CONFIG_CXL_MODULE */

/* AFU refcount management */
struct cxl_afu *cxl_afu_get(struct cxl_afu *afu)
{
return (get_device(&afu->dev) == NULL) ? NULL : afu;
}
EXPORT_SYMBOL_GPL(cxl_afu_get);

void cxl_afu_put(struct cxl_afu *afu)
{
put_device(&afu->dev);
}
EXPORT_SYMBOL_GPL(cxl_afu_put);

void cxl_slbia(struct mm_struct *mm)
{
struct cxl_calls *calls;
Expand Down
12 changes: 0 additions & 12 deletions drivers/misc/cxl/cxl.h
Original file line number Diff line number Diff line change
Expand Up @@ -440,18 +440,6 @@ struct cxl_afu {
bool enabled;
};

/* AFU refcount management */
static inline struct cxl_afu *cxl_afu_get(struct cxl_afu *afu)
{

return (get_device(&afu->dev) == NULL) ? NULL : afu;
}

static inline void cxl_afu_put(struct cxl_afu *afu)
{
put_device(&afu->dev);
}


struct cxl_irq_name {
struct list_head list;
Expand Down
4 changes: 4 additions & 0 deletions include/misc/cxl-base.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,15 @@ static inline void cxl_ctx_put(void)
atomic_dec(&cxl_use_count);
}

struct cxl_afu *cxl_afu_get(struct cxl_afu *afu);
void cxl_afu_put(struct cxl_afu *afu);
void cxl_slbia(struct mm_struct *mm);

#else /* CONFIG_CXL_BASE */

static inline bool cxl_ctx_in_use(void) { return false; }
static inline struct cxl_afu *cxl_afu_get(struct cxl_afu *afu) { return NULL; }
static inline void cxl_afu_put(struct cxl_afu *afu) {}
static inline void cxl_slbia(struct mm_struct *mm) {}

#endif /* CONFIG_CXL_BASE */
Expand Down

0 comments on commit 62ccf2d

Please sign in to comment.