Skip to content

Commit

Permalink
target/file: fix inclusive vfs_fsync_range() end
Browse files Browse the repository at this point in the history
Both of the file target's calls to vfs_fsync_range() got the end offset
off by one.  The range is inclusive, not exclusive.  It would sync a bit
more data than was required.

The sync path already tested the length of the range and fell back to
LLONG_MAX so I copied that pattern in the rw path.

This is untested. I found the errors by inspection while following other
code.

Signed-off-by: Zach Brown <zab@zabbo.net>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Zach Brown authored and Nicholas Bellinger committed Oct 8, 2014
1 parent 0d0f660 commit 62d3ab4
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions drivers/target/target_core_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ fd_execute_sync_cache(struct se_cmd *cmd)
} else {
start = cmd->t_task_lba * dev->dev_attrib.block_size;
if (cmd->data_length)
end = start + cmd->data_length;
end = start + cmd->data_length - 1;
else
end = LLONG_MAX;
}
Expand Down Expand Up @@ -680,7 +680,12 @@ fd_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
struct fd_dev *fd_dev = FD_DEV(dev);
loff_t start = cmd->t_task_lba *
dev->dev_attrib.block_size;
loff_t end = start + cmd->data_length;
loff_t end;

if (cmd->data_length)
end = start + cmd->data_length - 1;
else
end = LLONG_MAX;

vfs_fsync_range(fd_dev->fd_file, start, end, 1);
}
Expand Down

0 comments on commit 62d3ab4

Please sign in to comment.