Skip to content

Commit

Permalink
remoteproc: don't allow modular build
Browse files Browse the repository at this point in the history
Remoteproc started using dma_declare_coherent_memory recently, which is
a bad idea from drivers, and the maintainers agreed to fix that.  But
until that is fixed only allow building the driver built in so that we
can remove the dma_declare_coherent_memory export and prevent other
drivers from "accidentally" using it like remoteproc.  Note that the
driver would also leak the declared coherent memory on unload if it
actually was built as a module at the moment.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
  • Loading branch information
Christoph Hellwig committed Sep 4, 2019
1 parent 7a01ee4 commit 6334150
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/remoteproc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
menu "Remoteproc drivers"

config REMOTEPROC
tristate "Support for Remote Processor subsystem"
bool "Support for Remote Processor subsystem"
depends on HAS_DMA
select CRC32
select FW_LOADER
Expand Down

0 comments on commit 6334150

Please sign in to comment.