Skip to content

Commit

Permalink
ACPI: remove function tracing macros from drivers/acpi/*.c
Browse files Browse the repository at this point in the history
a few invocations appeared due to the SBS and other patches.

Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Len Brown committed Jul 1, 2006
1 parent 3f86b83 commit 635227e
Show file tree
Hide file tree
Showing 4 changed files with 56 additions and 138 deletions.
14 changes: 5 additions & 9 deletions drivers/acpi/cm_sbs.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ static int lock_battery_dir_cnt = 0;

struct proc_dir_entry *acpi_lock_ac_dir(void)
{
ACPI_FUNCTION_TRACE("acpi_lock_ac_dir");

down(&cm_sbs_sem);
if (!acpi_ac_dir) {
Expand All @@ -59,14 +58,13 @@ struct proc_dir_entry *acpi_lock_ac_dir(void)
"Cannot create %s\n", ACPI_AC_CLASS));
}
up(&cm_sbs_sem);
return (acpi_ac_dir);
return acpi_ac_dir;
}

EXPORT_SYMBOL(acpi_lock_ac_dir);

void acpi_unlock_ac_dir(struct proc_dir_entry *acpi_ac_dir_param)
{
ACPI_FUNCTION_TRACE("acpi_unlock_ac_dir");

down(&cm_sbs_sem);
if (acpi_ac_dir_param) {
Expand All @@ -83,7 +81,6 @@ EXPORT_SYMBOL(acpi_unlock_ac_dir);

struct proc_dir_entry *acpi_lock_battery_dir(void)
{
ACPI_FUNCTION_TRACE("acpi_lock_battery_dir");

down(&cm_sbs_sem);
if (!acpi_battery_dir) {
Expand All @@ -97,14 +94,13 @@ struct proc_dir_entry *acpi_lock_battery_dir(void)
"Cannot create %s\n", ACPI_BATTERY_CLASS));
}
up(&cm_sbs_sem);
return (acpi_battery_dir);
return acpi_battery_dir;
}

EXPORT_SYMBOL(acpi_lock_battery_dir);

void acpi_unlock_battery_dir(struct proc_dir_entry *acpi_battery_dir_param)
{
ACPI_FUNCTION_TRACE("acpi_unlock_battery_dir");

down(&cm_sbs_sem);
if (acpi_battery_dir_param) {
Expand All @@ -116,20 +112,20 @@ void acpi_unlock_battery_dir(struct proc_dir_entry *acpi_battery_dir_param)
acpi_battery_dir = 0;
}
up(&cm_sbs_sem);
return;
}

EXPORT_SYMBOL(acpi_unlock_battery_dir);

static int __init acpi_cm_sbs_init(void)
{
ACPI_FUNCTION_TRACE("acpi_cm_sbs_init");

if (acpi_disabled)
return_VALUE(0);
return 0;

init_MUTEX(&cm_sbs_sem);

return_VALUE(0);
return 0;
}

subsys_initcall(acpi_cm_sbs_init);
34 changes: 10 additions & 24 deletions drivers/acpi/i2c_ec.c
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,6 @@ static int acpi_ec_smb_read(struct acpi_ec_smbus *smbus, u8 address, u8 * data)
u8 val;
int err;

ACPI_FUNCTION_TRACE("acpi_ec_smb_read");

err = ec_read(smbus->base + address, &val);
if (!err) {
*data = val;
Expand All @@ -129,8 +127,6 @@ static int acpi_ec_smb_write(struct acpi_ec_smbus *smbus, u8 address, u8 data)
{
int err;

ACPI_FUNCTION_TRACE("acpi_ec_smb_write");

err = ec_write(smbus->base + address, data);
return (err);
}
Expand All @@ -144,8 +140,6 @@ acpi_ec_smb_access(struct i2c_adapter *adap, u16 addr, unsigned short flags,
unsigned char protocol, len = 0, pec, temp[2] = { 0, 0 };
int i;

ACPI_FUNCTION_TRACE("acpi_ec_smb_access");

if (read_write == I2C_SMBUS_READ) {
protocol = ACPI_EC_SMB_PRTCL_READ;
} else {
Expand Down Expand Up @@ -290,7 +284,6 @@ acpi_ec_smb_access(struct i2c_adapter *adap, u16 addr, unsigned short flags,

static u32 acpi_ec_smb_func(struct i2c_adapter *adapter)
{
ACPI_FUNCTION_TRACE("acpi_ec_smb_func");

return (I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
Expand All @@ -312,22 +305,20 @@ static int acpi_ec_hc_add(struct acpi_device *device)
struct acpi_ec_hc *ec_hc;
struct acpi_ec_smbus *smbus;

ACPI_FUNCTION_TRACE("acpi_ec_hc_add");

if (!device) {
return_VALUE(-EINVAL);
return -EINVAL;
}

ec_hc = kmalloc(sizeof(struct acpi_ec_hc), GFP_KERNEL);
if (!ec_hc) {
return_VALUE(-ENOMEM);
return -ENOMEM;
}
memset(ec_hc, 0, sizeof(struct acpi_ec_hc));

smbus = kmalloc(sizeof(struct acpi_ec_smbus), GFP_KERNEL);
if (!smbus) {
kfree(ec_hc);
return_VALUE(-ENOMEM);
return -ENOMEM;
}
memset(smbus, 0, sizeof(struct acpi_ec_smbus));

Expand All @@ -341,7 +332,7 @@ static int acpi_ec_hc_add(struct acpi_device *device)
ACPI_DEBUG_PRINT((ACPI_DB_WARN, "Error obtaining _EC\n"));
kfree(ec_hc->smbus);
kfree(smbus);
return_VALUE(-EIO);
return -EIO;
}

smbus->ec = acpi_driver_data(device->parent);
Expand All @@ -357,56 +348,51 @@ static int acpi_ec_hc_add(struct acpi_device *device)
"EC SMBus adapter: Failed to register adapter\n"));
kfree(smbus);
kfree(ec_hc);
return_VALUE(-EIO);
return -EIO;
}

ec_hc->smbus = smbus;

printk(KERN_INFO PREFIX "%s [%s]\n",
acpi_device_name(device), acpi_device_bid(device));

return_VALUE(AE_OK);
return AE_OK;
}

static int acpi_ec_hc_remove(struct acpi_device *device, int type)
{
struct acpi_ec_hc *ec_hc;

ACPI_FUNCTION_TRACE("acpi_ec_hc_remove");

if (!device) {
return_VALUE(-EINVAL);
return -EINVAL;
}
ec_hc = acpi_driver_data(device);

i2c_del_adapter(&ec_hc->smbus->adapter);
kfree(ec_hc->smbus);
kfree(ec_hc);

return_VALUE(AE_OK);
return AE_OK;
}

static int __init acpi_ec_hc_init(void)
{
int result;

ACPI_FUNCTION_TRACE("acpi_ec_hc_init");
result = acpi_bus_register_driver(&acpi_ec_hc_driver);
if (result < 0) {
return_VALUE(-ENODEV);
return -ENODEV;
}
return_VALUE(0);
return 0;
}

static void __exit acpi_ec_hc_exit(void)
{
ACPI_FUNCTION_TRACE("acpi_ec_hc_exit");
acpi_bus_unregister_driver(&acpi_ec_hc_driver);
}

struct acpi_ec_hc *acpi_get_ec_hc(struct acpi_device *device)
{
ACPI_FUNCTION_TRACE("acpi_get_ec_hc");
return ((struct acpi_ec_hc *)acpi_driver_data(device->parent));
}

Expand Down
4 changes: 1 addition & 3 deletions drivers/acpi/numa.c
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,10 @@ int acpi_get_node(acpi_handle *handle)
{
int pxm, node = -1;

ACPI_FUNCTION_TRACE("acpi_get_node");

pxm = acpi_get_pxm(handle);
if (pxm >= 0)
node = acpi_map_pxm_to_node(pxm);

return_VALUE(node);
return node;
}
EXPORT_SYMBOL(acpi_get_node);
Loading

0 comments on commit 635227e

Please sign in to comment.