Skip to content

Commit

Permalink
HID: roccat: Fix code style issues
Browse files Browse the repository at this point in the history
Missing whitespace, semi-colon after macro, and a duplicated out of
memory message.

Signed-off-by: Hans Duedal <hans.duedal@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Hans Duedal authored and Jiri Kosina committed Oct 29, 2014
1 parent b905811 commit 6354b7e
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/hid/hid-roccat-kone.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ static void kone_profile_activated(struct kone_device *kone, uint new_profile)
static void kone_profile_report(struct kone_device *kone, uint new_profile)
{
struct kone_roccat_report roccat_report;

roccat_report.event = kone_mouse_event_switch_profile;
roccat_report.value = new_profile;
roccat_report.key = 0;
Expand Down Expand Up @@ -163,6 +164,7 @@ static int kone_set_settings(struct usb_device *usb_dev,
struct kone_settings const *settings)
{
int retval;

retval = kone_send(usb_dev, kone_command_settings,
settings, sizeof(struct kone_settings));
if (retval)
Expand Down Expand Up @@ -387,7 +389,7 @@ static struct bin_attribute bin_attr_profile##number = { \
.read = kone_sysfs_read_profilex, \
.write = kone_sysfs_write_profilex, \
.private = &profile_numbers[number-1], \
};
}
PROFILE_ATTR(1);
PROFILE_ATTR(2);
PROFILE_ATTR(3);
Expand Down Expand Up @@ -456,6 +458,7 @@ static ssize_t kone_sysfs_show_tcu(struct device *dev,
static int kone_tcu_command(struct usb_device *usb_dev, int number)
{
unsigned char value;

value = number;
return kone_send(usb_dev, kone_command_calibrate, &value, 1);
}
Expand Down Expand Up @@ -697,10 +700,8 @@ static int kone_init_specials(struct hid_device *hdev)
== USB_INTERFACE_PROTOCOL_MOUSE) {

kone = kzalloc(sizeof(*kone), GFP_KERNEL);
if (!kone) {
hid_err(hdev, "can't alloc device descriptor\n");
if (!kone)
return -ENOMEM;
}
hid_set_drvdata(hdev, kone);

retval = kone_init_kone_device_struct(usb_dev, kone);
Expand Down

0 comments on commit 6354b7e

Please sign in to comment.