Skip to content

Commit

Permalink
[media] rc: fix sysfs entry for mceusb and streamzap
Browse files Browse the repository at this point in the history
When trying to create persistent device names for mceusb and streamzap
devices, I noticed that their respective drivers are not creating the rc
device as a child of the USB device. Rather it creates it as virtual
device. As a result, udev cannot use the USB device information to
create persistent device names for event and lirc devices associated
with the rc device. Not having persistent device names makes it more
difficult to make use of the devices in userspace as their names can
change.

Signed-off-by: Paul Bender <pebender@gmail.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Paul Bender authored and Mauro Carvalho Chehab committed Dec 20, 2010
1 parent 1338c92 commit 635f76b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
7 changes: 5 additions & 2 deletions drivers/media/IR/mceusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
#include <linux/device.h>
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/usb.h>
#include <linux/input.h>
#include <linux/usb.h>
#include <linux/usb/input.h>
#include <media/ir-core.h>
#include <media/ir-common.h>

#define DRIVER_VERSION "1.91"
#define DRIVER_AUTHOR "Jarod Wilson <jarod@wilsonet.com>"
Expand Down Expand Up @@ -1079,6 +1079,9 @@ static struct input_dev *mceusb_init_input_dev(struct mceusb_dev *ir)

ir->props = props;

usb_to_input_id(ir->usbdev, &idev->id);
idev->dev.parent = ir->dev;

if (mceusb_model[ir->model].rc_map)
rc_map = mceusb_model[ir->model].rc_map;

Expand Down
6 changes: 5 additions & 1 deletion drivers/media/IR/streamzap.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@
#include <linux/device.h>
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/usb.h>
#include <linux/input.h>
#include <linux/usb.h>
#include <linux/usb/input.h>
#include <media/ir-core.h>

#define DRIVER_VERSION "1.61"
Expand Down Expand Up @@ -332,6 +333,9 @@ static struct input_dev *streamzap_init_input_dev(struct streamzap_ir *sz)

sz->props = props;

usb_to_input_id(sz->usbdev, &idev->id);
idev->dev.parent = sz->dev;

ret = ir_input_register(idev, RC_MAP_STREAMZAP, props, DRIVER_NAME);
if (ret < 0) {
dev_err(dev, "remote input device register failed\n");
Expand Down

0 comments on commit 635f76b

Please sign in to comment.