Skip to content

Commit

Permalink
dm thin metadata: use true/false for bool variable
Browse files Browse the repository at this point in the history
Fixes coccicheck warning:

drivers/md/dm-thin-metadata.c:814:3-14: WARNING: Assignment of 0/1 to bool variable
drivers/md/dm-thin-metadata.c:1109:1-12: WARNING: Assignment of 0/1 to bool variable
drivers/md/dm-thin-metadata.c:1621:1-12: WARNING: Assignment of 0/1 to bool variable
drivers/md/dm-thin-metadata.c:1652:1-12: WARNING: Assignment of 0/1 to bool variable
drivers/md/dm-thin-metadata.c:1706:1-12: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
  • Loading branch information
zhengbin authored and Mike Snitzer committed Jan 7, 2020
1 parent 1d1dda8 commit 63ee92d
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/md/dm-thin-metadata.c
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ static int __write_changed_details(struct dm_pool_metadata *pmd)
return r;

if (td->open_count)
td->changed = 0;
td->changed = false;
else {
list_del(&td->list);
kfree(td);
Expand Down Expand Up @@ -1106,7 +1106,7 @@ static int __set_snapshot_details(struct dm_pool_metadata *pmd,
if (r)
return r;

td->changed = 1;
td->changed = true;
td->snapshotted_time = time;

snap->mapped_blocks = td->mapped_blocks;
Expand Down Expand Up @@ -1618,7 +1618,7 @@ static int __insert(struct dm_thin_device *td, dm_block_t block,
if (r)
return r;

td->changed = 1;
td->changed = true;
if (inserted)
td->mapped_blocks++;

Expand Down Expand Up @@ -1649,7 +1649,7 @@ static int __remove(struct dm_thin_device *td, dm_block_t block)
return r;

td->mapped_blocks--;
td->changed = 1;
td->changed = true;

return 0;
}
Expand Down Expand Up @@ -1703,7 +1703,7 @@ static int __remove_range(struct dm_thin_device *td, dm_block_t begin, dm_block_
}

td->mapped_blocks -= total_count;
td->changed = 1;
td->changed = true;

/*
* Reinsert the mapping tree.
Expand Down

0 comments on commit 63ee92d

Please sign in to comment.