Skip to content

Commit

Permalink
eql: Convert printks to pr_<level> and netdev_<level>
Browse files Browse the repository at this point in the history
Add pr_fmt.

Removed trailing "\n" from version,
add back via pr_info("%s\n", version);

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Joe Perches authored and David S. Miller committed Mar 3, 2011
1 parent 967faf3 commit 63f9742
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions drivers/net/eql.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@
* Sorry, I had to rewrite most of this for 2.5.x -DaveM
*/

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include <linux/capability.h>
#include <linux/module.h>
#include <linux/kernel.h>
Expand Down Expand Up @@ -162,7 +164,7 @@ static void eql_timer(unsigned long param)
}

static const char version[] __initconst =
"Equalizer2002: Simon Janes (simon@ncm.com) and David S. Miller (davem@redhat.com)\n";
"Equalizer2002: Simon Janes (simon@ncm.com) and David S. Miller (davem@redhat.com)";

static const struct net_device_ops eql_netdev_ops = {
.ndo_open = eql_open,
Expand Down Expand Up @@ -204,8 +206,8 @@ static int eql_open(struct net_device *dev)
equalizer_t *eql = netdev_priv(dev);

/* XXX We should force this off automatically for the user. */
printk(KERN_INFO "%s: remember to turn off Van-Jacobson compression on "
"your slave devices.\n", dev->name);
netdev_info(dev,
"remember to turn off Van-Jacobson compression on your slave devices\n");

BUG_ON(!list_empty(&eql->queue.all_slaves));

Expand Down Expand Up @@ -591,7 +593,7 @@ static int __init eql_init_module(void)
{
int err;

printk(version);
pr_info("%s\n", version);

dev_eql = alloc_netdev(sizeof(equalizer_t), "eql", eql_setup);
if (!dev_eql)
Expand Down

0 comments on commit 63f9742

Please sign in to comment.