Skip to content

Commit

Permalink
can: j1939: replace fall through comment by fallthrough pseudo-keyword
Browse files Browse the repository at this point in the history
Replace the existing /* fall through */ comments the new
pseudo-keyword macro fallthrough.

Cc: Robin van der Gracht <robin@protonic.nl>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/r/20210616102811.2449426-3-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Marc Kleine-Budde committed Jul 25, 2021
1 parent 3331287 commit 641ba6d
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions net/can/j1939/transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -1264,12 +1264,14 @@ static bool j1939_xtp_rx_cmd_bad_pgn(struct j1939_session *session,
break;

case J1939_ETP_CMD_RTS:
case J1939_TP_CMD_RTS: /* fall through */
fallthrough;
case J1939_TP_CMD_RTS:
abort = J1939_XTP_ABORT_BUSY;
break;

case J1939_ETP_CMD_CTS:
case J1939_TP_CMD_CTS: /* fall through */
fallthrough;
case J1939_TP_CMD_CTS:
abort = J1939_XTP_ABORT_ECTS_UNXPECTED_PGN;
break;

Expand All @@ -1278,7 +1280,8 @@ static bool j1939_xtp_rx_cmd_bad_pgn(struct j1939_session *session,
break;

case J1939_ETP_CMD_EOMA:
case J1939_TP_CMD_EOMA: /* fall through */
fallthrough;
case J1939_TP_CMD_EOMA:
abort = J1939_XTP_ABORT_OTHER;
break;

Expand Down Expand Up @@ -1793,7 +1796,8 @@ static void j1939_xtp_rx_dat_one(struct j1939_session *session,
break;
fallthrough;
case J1939_TP_CMD_BAM:
case J1939_TP_CMD_CTS: /* fall through */
fallthrough;
case J1939_TP_CMD_CTS:
if (skcb->addr.type != J1939_ETP)
break;
fallthrough;
Expand Down Expand Up @@ -1996,7 +2000,8 @@ static void j1939_tp_cmd_recv(struct j1939_priv *priv, struct sk_buff *skb)
extd = J1939_ETP;
fallthrough;
case J1939_TP_CMD_BAM:
case J1939_TP_CMD_RTS: /* fall through */
fallthrough;
case J1939_TP_CMD_RTS:
if (skcb->addr.type != extd)
return;

Expand Down

0 comments on commit 641ba6d

Please sign in to comment.