Skip to content

Commit

Permalink
[BLOCK] elevator switch fixes/cleanup
Browse files Browse the repository at this point in the history
- 100msec sleep is a little excessive, lots of requests can complete
  in that timeframe. Use 10msec instead.
- Rename QUEUE_FLAG_BYPASS to QUEUE_FLAG_ELVSWITCH to indicate what
  is going on.

Signed-off-by: Jens Axboe <axboe@suse.de>
  • Loading branch information
Jens Axboe authored and Jens Axboe committed Oct 28, 2005
1 parent cb98fc8 commit 64521d1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions drivers/block/elevator.c
Original file line number Diff line number Diff line change
Expand Up @@ -671,14 +671,14 @@ static void elevator_switch(request_queue_t *q, struct elevator_type *new_e)
*/
spin_lock_irq(q->queue_lock);

set_bit(QUEUE_FLAG_BYPASS, &q->queue_flags);
set_bit(QUEUE_FLAG_ELVSWITCH, &q->queue_flags);

while (q->elevator->ops->elevator_dispatch_fn(q, 1))
;

while (q->rq.elvpriv) {
spin_unlock_irq(q->queue_lock);
msleep(100);
msleep(10);
spin_lock_irq(q->queue_lock);
}

Expand All @@ -703,7 +703,7 @@ static void elevator_switch(request_queue_t *q, struct elevator_type *new_e)
* finally exit old elevator and turn off BYPASS.
*/
elevator_exit(old_elevator);
clear_bit(QUEUE_FLAG_BYPASS, &q->queue_flags);
clear_bit(QUEUE_FLAG_ELVSWITCH, &q->queue_flags);
return;

fail_register:
Expand All @@ -716,7 +716,7 @@ static void elevator_switch(request_queue_t *q, struct elevator_type *new_e)
fail:
q->elevator = old_elevator;
elv_register_queue(q);
clear_bit(QUEUE_FLAG_BYPASS, &q->queue_flags);
clear_bit(QUEUE_FLAG_ELVSWITCH, &q->queue_flags);
kfree(e);
error:
elevator_put(new_e);
Expand Down
2 changes: 1 addition & 1 deletion drivers/block/ll_rw_blk.c
Original file line number Diff line number Diff line change
Expand Up @@ -1940,7 +1940,7 @@ static struct request *get_request(request_queue_t *q, int rw, struct bio *bio,
if (rl->count[rw] >= queue_congestion_on_threshold(q))
set_queue_congested(q, rw);

priv = !test_bit(QUEUE_FLAG_BYPASS, &q->queue_flags);
priv = !test_bit(QUEUE_FLAG_ELVSWITCH, &q->queue_flags);
if (priv)
rl->elvpriv++;

Expand Down
2 changes: 1 addition & 1 deletion include/linux/blkdev.h
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ enum {
#define QUEUE_FLAG_DEAD 5 /* queue being torn down */
#define QUEUE_FLAG_REENTER 6 /* Re-entrancy avoidance */
#define QUEUE_FLAG_PLUGGED 7 /* queue is plugged */
#define QUEUE_FLAG_BYPASS 8 /* don't use elevator, just do FIFO */
#define QUEUE_FLAG_ELVSWITCH 8 /* don't use elevator, just do FIFO */
#define QUEUE_FLAG_FLUSH 9 /* doing barrier flush sequence */

#define blk_queue_plugged(q) test_bit(QUEUE_FLAG_PLUGGED, &(q)->queue_flags)
Expand Down

0 comments on commit 64521d1

Please sign in to comment.