Skip to content

Commit

Permalink
Merge branch 'encx24j600-fixes'
Browse files Browse the repository at this point in the history
Javier Martinez Canillas says:

====================
net: encx24j600: Fix SPI driver module autoload

Recently I've been trying to fix module autoloading for all SPI drivers and
found that the encx24j600 driver does not fill module alias information due
missing a MODULE_DEVICE_TABLE() so module autload won't work and the driver
Kconfig symbol is tristate which means the driver can be built as a module.

But also the SPI id table is not correctly defined so this series fixes both
issues.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Nov 2, 2015
2 parents 322cf7e + 07f56c6 commit 64cf370
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/net/ethernet/microchip/encx24j600.c
Original file line number Diff line number Diff line change
Expand Up @@ -1094,9 +1094,11 @@ static int encx24j600_spi_remove(struct spi_device *spi)
return 0;
}

static const struct spi_device_id encx24j600_spi_id_table = {
.name = "encx24j600"
static const struct spi_device_id encx24j600_spi_id_table[] = {
{ .name = "encx24j600" },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(spi, encx24j600_spi_id_table);

static struct spi_driver encx24j600_spi_net_driver = {
.driver = {
Expand All @@ -1106,7 +1108,7 @@ static struct spi_driver encx24j600_spi_net_driver = {
},
.probe = encx24j600_spi_probe,
.remove = encx24j600_spi_remove,
.id_table = &encx24j600_spi_id_table,
.id_table = encx24j600_spi_id_table,
};

static int __init encx24j600_init(void)
Expand Down

0 comments on commit 64cf370

Please sign in to comment.