Skip to content

Commit

Permalink
atl1e: Remove non-implementation of ethtool set_msglevel() operation
Browse files Browse the repository at this point in the history
Unimplemented operations should not silently fail.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ben Hutchings authored and David S. Miller committed Dec 3, 2009
1 parent 95fec16 commit 650de8d
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/net/atl1e/atl1e_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@ static u32 atl1e_get_msglevel(struct net_device *netdev)
#endif
}

static void atl1e_set_msglevel(struct net_device *netdev, u32 data)
{
}

static int atl1e_get_regs_len(struct net_device *netdev)
{
return AT_REGS_LEN * sizeof(u32);
Expand Down Expand Up @@ -382,7 +378,6 @@ static const struct ethtool_ops atl1e_ethtool_ops = {
.get_wol = atl1e_get_wol,
.set_wol = atl1e_set_wol,
.get_msglevel = atl1e_get_msglevel,
.set_msglevel = atl1e_set_msglevel,
.nway_reset = atl1e_nway_reset,
.get_link = ethtool_op_get_link,
.get_eeprom_len = atl1e_get_eeprom_len,
Expand Down

0 comments on commit 650de8d

Please sign in to comment.