Skip to content

Commit

Permalink
drm/nouveau/mmu/r535: uninitialized variable in r535_bar_new_()
Browse files Browse the repository at this point in the history
If gf100_bar_new_() fails then "bar" is not initialized.

Fixes: 5bf0257 ("drm/nouveau/mmu/r535: initial support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/dab21df7-4d90-4479-97d8-97e5d228c714@moroto.mountain
  • Loading branch information
Dan Carpenter authored and Danilo Krummrich committed Feb 16, 2024
1 parent 0affdba commit 6532379
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/gpu/drm/nouveau/nvkm/subdev/bar/r535.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,12 +168,11 @@ r535_bar_new_(const struct nvkm_bar_func *hw, struct nvkm_device *device,
rm->flush = r535_bar_flush;

ret = gf100_bar_new_(rm, device, type, inst, &bar);
*pbar = bar;
if (ret) {
if (!bar)
kfree(rm);
kfree(rm);
return ret;
}
*pbar = bar;

bar->flushBAR2PhysMode = ioremap(device->func->resource_addr(device, 3), PAGE_SIZE);
if (!bar->flushBAR2PhysMode)
Expand Down

0 comments on commit 6532379

Please sign in to comment.