Skip to content

Commit

Permalink
perf test: Add pipe output testing for annotate
Browse files Browse the repository at this point in the history
Parameterize the basic testing to generate directly a perf.data file
or to generate/use one from pipe input or output.  To simplify the
refactor move some of the head/grep logic around. Use "-q" with grep
to make the test output cleaner.

Signed-off-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250311211635.541090-1-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
  • Loading branch information
Ian Rogers authored and Namhyung Kim committed Mar 15, 2025
1 parent 3a86d63 commit 658b34c
Showing 1 changed file with 40 additions and 16 deletions.
56 changes: 40 additions & 16 deletions tools/perf/tests/shell/annotate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,54 +35,78 @@ trap_cleanup() {
trap trap_cleanup EXIT TERM INT

test_basic() {
echo "Basic perf annotate test"
if ! perf record -o "${perfdata}" ${testprog} 2> /dev/null
mode=$1
echo "${mode} perf annotate test"
if [ "x${mode}" == "xBasic" ]
then
echo "Basic annotate [Failed: perf record]"
perf record -o "${perfdata}" ${testprog} 2> /dev/null
else
perf record -o - ${testprog} 2> /dev/null > "${perfdata}"
fi
if [ "x$?" != "x0" ]
then
echo "${mode} annotate [Failed: perf record]"
err=1
return
fi

# Generate the annotated output file
perf annotate --no-demangle -i "${perfdata}" --stdio 2> /dev/null | head -250 > "${perfout}"
if [ "x${mode}" == "xBasic" ]
then
perf annotate --no-demangle -i "${perfdata}" --stdio 2> /dev/null > "${perfout}"
else
perf annotate --no-demangle -i - --stdio 2> /dev/null < "${perfdata}" > "${perfout}"
fi

# check if it has the target symbol
if ! grep "${testsym}" "${perfout}"
if ! head -250 "${perfout}" | grep -q "${testsym}"
then
echo "Basic annotate [Failed: missing target symbol]"
echo "${mode} annotate [Failed: missing target symbol]"
err=1
return
fi

# check if it has the disassembly lines
if ! grep "${disasm_regex}" "${perfout}"
if ! head -250 "${perfout}" | grep -q "${disasm_regex}"
then
echo "Basic annotate [Failed: missing disasm output from default disassembler]"
echo "${mode} annotate [Failed: missing disasm output from default disassembler]"
err=1
return
fi

# check again with a target symbol name
if ! perf annotate --no-demangle -i "${perfdata}" "${testsym}" 2> /dev/null | \
head -250 | grep -m 3 "${disasm_regex}"
if [ "x${mode}" == "xBasic" ]
then
echo "Basic annotate [Failed: missing disasm output when specifying the target symbol]"
perf annotate --no-demangle -i "${perfdata}" "${testsym}" 2> /dev/null > "${perfout}"
else
perf annotate --no-demangle -i - "${testsym}" 2> /dev/null < "${perfdata}" > "${perfout}"
fi

if ! head -250 "${perfout}"| grep -q -m 3 "${disasm_regex}"
then
echo "${mode} annotate [Failed: missing disasm output when specifying the target symbol]"
err=1
return
fi

# check one more with external objdump tool (forced by --objdump option)
if ! perf annotate --no-demangle -i "${perfdata}" --objdump=objdump 2> /dev/null | \
head -250 | grep -m 3 "${disasm_regex}"
if [ "x${mode}" == "xBasic" ]
then
perf annotate --no-demangle -i "${perfdata}" --objdump=objdump 2> /dev/null > "${perfout}"
else
perf annotate --no-demangle -i - "${testsym}" 2> /dev/null < "${perfdata}" > "${perfout}"
fi
if ! head -250 "${perfout}" | grep -q -m 3 "${disasm_regex}"
then
echo "Basic annotate [Failed: missing disasm output from non default disassembler (using --objdump)]"
echo "${mode} annotate [Failed: missing disasm output from non default disassembler (using --objdump)]"
err=1
return
fi
echo "Basic annotate test [Success]"
echo "${mode} annotate test [Success]"
}

test_basic
test_basic Basic
test_basic Pipe

cleanup
exit $err

0 comments on commit 658b34c

Please sign in to comment.