Skip to content

Commit

Permalink
net: dsa: Improve subordinate PHY error message
Browse files Browse the repository at this point in the history
It is not very informative to know the DSA master device when a
subordinate network device fails to get its PHY setup. Provide the
device name and capitalize PHY while we are it.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Florian Fainelli authored and David S. Miller committed Jun 30, 2020
1 parent 9d9f95a commit 65951a9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/dsa/slave.c
Original file line number Diff line number Diff line change
Expand Up @@ -1795,7 +1795,8 @@ int dsa_slave_create(struct dsa_port *port)

ret = dsa_slave_phy_setup(slave_dev);
if (ret) {
netdev_err(master, "error %d setting up slave phy\n", ret);
netdev_err(master, "error %d setting up slave PHY for %s\n",
ret, slave_dev->name);
goto out_gcells;
}

Expand Down

0 comments on commit 65951a9

Please sign in to comment.