Skip to content

Commit

Permalink
ch_ktls: don't free skb before sending FIN
Browse files Browse the repository at this point in the history
If its a last packet and fin is set. Make sure FIN is informed
to HW before skb gets freed.

Fixes: 429765a ("chcr: handle partial end part of a record")
Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Rohit Maheshwari authored and Jakub Kicinski committed Nov 12, 2020
1 parent 9478e08 commit 659bf03
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
Original file line number Diff line number Diff line change
Expand Up @@ -1932,6 +1932,9 @@ static int chcr_ktls_xmit(struct sk_buff *skb, struct net_device *dev)
flags);
goto out;
}

if (th->fin)
skb_get(skb);
}

if (unlikely(tls_record_is_start_marker(record))) {
Expand Down Expand Up @@ -2006,8 +2009,11 @@ static int chcr_ktls_xmit(struct sk_buff *skb, struct net_device *dev)
__skb_frag_unref(&record->frags[i]);
}
/* if any failure, come out from the loop. */
if (ret)
if (ret) {
if (th->fin)
dev_kfree_skb_any(skb);
return NETDEV_TX_OK;
}

/* length should never be less than 0 */
WARN_ON(data_len < 0);
Expand All @@ -2020,8 +2026,10 @@ static int chcr_ktls_xmit(struct sk_buff *skb, struct net_device *dev)
/* tcp finish is set, send a separate tcp msg including all the options
* as well.
*/
if (th->fin)
if (th->fin) {
chcr_ktls_write_tcp_options(tx_info, skb, q, tx_info->tx_chan);
dev_kfree_skb_any(skb);
}

return NETDEV_TX_OK;
out:
Expand Down

0 comments on commit 659bf03

Please sign in to comment.