Skip to content

Commit

Permalink
tracing: Make filter_check_discard() local
Browse files Browse the repository at this point in the history
Nothing outside of the tracing directory calls filter_check_discard() or
check_filter_check_discard(). They should not be called by modules. Move
their prototypes into the local tracing header and remove their
EXPORT_SYMBOL() macros.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Steven Rostedt (Red Hat) committed Apr 27, 2016
1 parent dad56ee commit 65da9a0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
6 changes: 0 additions & 6 deletions include/linux/trace_events.h
Original file line number Diff line number Diff line change
Expand Up @@ -413,12 +413,6 @@ enum event_trigger_type {

extern int filter_match_preds(struct event_filter *filter, void *rec);

extern int filter_check_discard(struct trace_event_file *file, void *rec,
struct ring_buffer *buffer,
struct ring_buffer_event *event);
extern int call_filter_check_discard(struct trace_event_call *call, void *rec,
struct ring_buffer *buffer,
struct ring_buffer_event *event);
extern enum event_trigger_type event_triggers_call(struct trace_event_file *file,
void *rec);
extern void event_triggers_post_call(struct trace_event_file *file,
Expand Down
2 changes: 0 additions & 2 deletions kernel/trace/trace.c
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,6 @@ int filter_check_discard(struct trace_event_file *file, void *rec,

return 0;
}
EXPORT_SYMBOL_GPL(filter_check_discard);

int call_filter_check_discard(struct trace_event_call *call, void *rec,
struct ring_buffer *buffer,
Expand All @@ -332,7 +331,6 @@ int call_filter_check_discard(struct trace_event_call *call, void *rec,

return 0;
}
EXPORT_SYMBOL_GPL(call_filter_check_discard);

static cycle_t buffer_ftrace_now(struct trace_buffer *buf, int cpu)
{
Expand Down
6 changes: 6 additions & 0 deletions kernel/trace/trace.h
Original file line number Diff line number Diff line change
Expand Up @@ -1065,6 +1065,12 @@ struct trace_subsystem_dir {
int nr_events;
};

extern int filter_check_discard(struct trace_event_file *file, void *rec,
struct ring_buffer *buffer,
struct ring_buffer_event *event);
extern int call_filter_check_discard(struct trace_event_call *call, void *rec,
struct ring_buffer *buffer,
struct ring_buffer_event *event);
/*
* Helper function for event_trigger_unlock_commit{_regs}().
* If there are event triggers attached to this event that requires
Expand Down

0 comments on commit 65da9a0

Please sign in to comment.