Skip to content

Commit

Permalink
fs/ufs: remove extra superblock write on unmount
Browse files Browse the repository at this point in the history
UFS calls 'ufs_write_super()' from 'ufs_put_super()' in order to write the
superblocks to the media. However, it is not needed because VFS calls
'->sync_fs()' before calling '->put_super()' - so by the time we are in
'ufs_write_super()', the superblocks are already synchronized.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Artem Bityutskiy authored and Al Viro committed Jul 22, 2012
1 parent 9d46be2 commit 65e5e83
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions fs/ufs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1238,9 +1238,6 @@ static void ufs_put_super(struct super_block *sb)

UFSD("ENTER\n");

if (sb->s_dirt)
ufs_write_super(sb);

if (!(sb->s_flags & MS_RDONLY))
ufs_put_super_internal(sb);

Expand Down

0 comments on commit 65e5e83

Please sign in to comment.