Skip to content

Commit

Permalink
block: remove bogus comments in __bio_add_pc_page
Browse files Browse the repository at this point in the history
We are never called with file system pages by defintions for the
passthrough interface, and we also never undo any addition later
these days.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Christoph Hellwig authored and Jens Axboe committed Apr 30, 2019
1 parent 4713839 commit 6601e44
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions block/bio.c
Original file line number Diff line number Diff line change
Expand Up @@ -724,11 +724,6 @@ static int __bio_add_pc_page(struct request_queue *q, struct bio *bio,
if (((bio->bi_iter.bi_size + len) >> 9) > queue_max_hw_sectors(q))
return 0;

/*
* For filesystems with a blocksize smaller than the pagesize
* we will often be called with the same page as last time and
* a consecutive offset. Optimize this special case.
*/
if (bio->bi_vcnt > 0) {
bvec = &bio->bi_io_vec[bio->bi_vcnt - 1];

Expand Down Expand Up @@ -760,10 +755,6 @@ static int __bio_add_pc_page(struct request_queue *q, struct bio *bio,
if (bio->bi_phys_segments >= queue_max_segments(q))
return 0;

/*
* setup the new entry, we might clear it again later if we
* cannot add the page
*/
bvec = &bio->bi_io_vec[bio->bi_vcnt];
bvec->bv_page = page;
bvec->bv_len = len;
Expand Down

0 comments on commit 6601e44

Please sign in to comment.