Skip to content

Commit

Permalink
drm: rcar-du: Remove an unneeded NULL check
Browse files Browse the repository at this point in the history
"params" can't be NULL here.  The next lines assume that we either
hit the break statement of "params->mpixelclock == ~0UL".  The
inconsistent NULL checking makes static checkers complain.  I've just
removed the test.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
  • Loading branch information
Dan Carpenter authored and Laurent Pinchart committed Aug 3, 2017
1 parent f411246 commit 6608874
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ static int rcar_hdmi_phy_configure(struct dw_hdmi *hdmi,
{
const struct rcar_hdmi_phy_params *params = rcar_hdmi_phy_params;

for (; params && params->mpixelclock != ~0UL; ++params) {
for (; params->mpixelclock != ~0UL; ++params) {
if (mpixelclock <= params->mpixelclock)
break;
}
Expand Down

0 comments on commit 6608874

Please sign in to comment.