Skip to content

Commit

Permalink
net/ibm/emac: bump version numbers for correct work with ethtool
Browse files Browse the repository at this point in the history
The size of the MAC register dump used to be the size specified by the
reg property in the device tree.  Userland has no good way of finding
out that size, and it was not specified consistently for each MAC type,
so ethtool would end up printing junk at the end of the register dump
if the device tree didn't match the size it assumed.

Using the new version numbers indicates unambiguously that the size of
the MAC register dump is dependent only on the MAC type.

Fixes: 5369c71 ("net/ibm/emac: fix size of emac dump memory areas")
Signed-off-by: Ivan Mikhaylov <ivan@ru.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ivan Mikhaylov authored and David S. Miller committed Sep 29, 2015
1 parent 51359bf commit 661dfc6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/ethernet/ibm/emac/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,8 @@ struct emac_ethtool_regs_subhdr {
u32 index;
};

#define EMAC_ETHTOOL_REGS_VER 0
#define EMAC4_ETHTOOL_REGS_VER 1
#define EMAC4SYNC_ETHTOOL_REGS_VER 2
#define EMAC_ETHTOOL_REGS_VER 3
#define EMAC4_ETHTOOL_REGS_VER 4
#define EMAC4SYNC_ETHTOOL_REGS_VER 5

#endif /* __IBM_NEWEMAC_CORE_H */

0 comments on commit 661dfc6

Please sign in to comment.