Skip to content

Commit

Permalink
perf/core: Fix perf_mmap() failure path
Browse files Browse the repository at this point in the history
When f_ops->mmap() returns failure, m_ops->close() is *not* called.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com>
Link: https://lore.kernel.org/r/20241104135519.248358497@infradead.org
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed Mar 4, 2025
1 parent 4eabf53 commit 66477c7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/events/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -6903,7 +6903,7 @@ static int perf_mmap(struct file *file, struct vm_area_struct *vma)
if (!ret)
ret = map_range(rb, vma);

if (event->pmu->event_mapped)
if (!ret && event->pmu->event_mapped)
event->pmu->event_mapped(event, vma->vm_mm);

return ret;
Expand Down

0 comments on commit 66477c7

Please sign in to comment.