Skip to content

Commit

Permalink
ipv6: Fix tcp_v6_send_response transport header setting.
Browse files Browse the repository at this point in the history
My recent patch to remove the open-coded checksum sequence in
tcp_v6_send_response broke it as we did not set the transport
header pointer on the new packet.

Actually, there is code there trying to set the transport
header properly, but it sets it for the wrong skb ('skb'
instead of 'buff').

This bug was introduced by commit
a8fdf2b ("ipv6: Fix
tcp_v6_send_response(): it didn't set skb transport header")

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Herbert Xu authored and David S. Miller committed Apr 21, 2010
1 parent 8eabf95 commit 6651ffc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv6/tcp_ipv6.c
Original file line number Diff line number Diff line change
Expand Up @@ -1015,7 +1015,7 @@ static void tcp_v6_send_response(struct sk_buff *skb, u32 seq, u32 ack, u32 win,
skb_reserve(buff, MAX_HEADER + sizeof(struct ipv6hdr) + tot_len);

t1 = (struct tcphdr *) skb_push(buff, tot_len);
skb_reset_transport_header(skb);
skb_reset_transport_header(buff);

/* Swap the send and the receive. */
memset(t1, 0, sizeof(*t1));
Expand Down

0 comments on commit 6651ffc

Please sign in to comment.