Skip to content

Commit

Permalink
pktcdvd: fix defective misuses of pkt_<level>
Browse files Browse the repository at this point in the history
Fix thinkos where pkt_<level> needs a valid pktcdvd_device * and the
pointer is known to be NULL.

Signed-off-by: Joe Perches <joe@perches.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com> (go smatch!)
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Joe Perches authored and Linus Torvalds committed Sep 11, 2013
1 parent f3ded78 commit 666dc7c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/block/pktcdvd.c
Original file line number Diff line number Diff line change
Expand Up @@ -2360,8 +2360,8 @@ static void pkt_make_request(struct request_queue *q, struct bio *bio)

pd = q->queuedata;
if (!pd) {
pkt_err(pd, "%s incorrect request queue\n",
bdevname(bio->bi_bdev, b));
pr_err("%s incorrect request queue\n",
bdevname(bio->bi_bdev, b));
goto end_io;
}

Expand Down Expand Up @@ -2841,7 +2841,7 @@ static int pkt_remove_dev(dev_t pkt_dev)
break;
}
if (idx == MAX_WRITERS) {
pkt_dbg(1, pd, "dev not setup\n");
pr_debug("dev not setup\n");
ret = -ENXIO;
goto out;
}
Expand Down

0 comments on commit 666dc7c

Please sign in to comment.