Skip to content

Commit

Permalink
usb: isp1760: Set IRQF_SHARED flag in core code
Browse files Browse the repository at this point in the history
The IRQF_SHARED flag needs to be set regardless of the bus type. Don't
require glue code to set it manually.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Laurent Pinchart authored and Felipe Balbi committed Jan 27, 2015
1 parent 4b1a577 commit 667c45c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/host/isp1760-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ int isp1760_register(struct resource *mem, int irq, unsigned long irqflags,
if (IS_ERR(isp->regs))
return PTR_ERR(isp->regs);

ret = isp1760_hcd_register(&isp->hcd, isp->regs, mem, irq, irqflags,
dev, devflags);
ret = isp1760_hcd_register(&isp->hcd, isp->regs, mem, irq,
irqflags | IRQF_SHARED, dev, devflags);
if (ret < 0)
return ret;

Expand Down
9 changes: 4 additions & 5 deletions drivers/usb/host/isp1760-if.c
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@ static int isp1761_pci_probe(struct pci_dev *dev,
pci_set_master(dev);

dev->dev.dma_mask = NULL;
ret = isp1760_register(&dev->resource[3], dev->irq, IRQF_SHARED,
&dev->dev, devflags);
ret = isp1760_register(&dev->resource[3], dev->irq, 0, &dev->dev,
devflags);
if (ret < 0)
goto error;

Expand Down Expand Up @@ -190,7 +190,7 @@ static struct pci_driver isp1761_pci_driver = {

static int isp1760_plat_probe(struct platform_device *pdev)
{
unsigned long irqflags = IRQF_SHARED;
unsigned long irqflags;
unsigned int devflags = 0;
struct resource *mem_res;
struct resource *irq_res;
Expand All @@ -203,8 +203,7 @@ static int isp1760_plat_probe(struct platform_device *pdev)
pr_warning("isp1760: IRQ resource not available\n");
return -ENODEV;
}

irqflags |= irq_res->flags & IRQF_TRIGGER_MASK;
irqflags = irq_res->flags & IRQF_TRIGGER_MASK;

if (IS_ENABLED(CONFIG_OF) && pdev->dev.of_node) {
struct device_node *dp = pdev->dev.of_node;
Expand Down

0 comments on commit 667c45c

Please sign in to comment.