Skip to content

Commit

Permalink
block/xen-blkback: s/nr_pages/nr_segs/
Browse files Browse the repository at this point in the history
Make the code less confusing to read now that Linux may not have the
same page size as Xen.

Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
  • Loading branch information
Julien Grall authored and David Vrabel committed Jun 17, 2015
1 parent ee4b717 commit 6684fa1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions drivers/block/xen-blkback/blkback.c
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ static void xen_blkbk_unmap_and_respond(struct pending_req *req)
struct grant_page **pages = req->segments;
unsigned int invcount;

invcount = xen_blkbk_unmap_prepare(blkif, pages, req->nr_pages,
invcount = xen_blkbk_unmap_prepare(blkif, pages, req->nr_segs,
req->unmap, req->unmap_pages);

work->data = req;
Expand Down Expand Up @@ -915,7 +915,7 @@ static int xen_blkbk_map_seg(struct pending_req *pending_req)
int rc;

rc = xen_blkbk_map(pending_req->blkif, pending_req->segments,
pending_req->nr_pages,
pending_req->nr_segs,
(pending_req->operation != BLKIF_OP_READ));

return rc;
Expand All @@ -931,7 +931,7 @@ static int xen_blkbk_parse_indirect(struct blkif_request *req,
int indirect_grefs, rc, n, nseg, i;
struct blkif_request_segment *segments = NULL;

nseg = pending_req->nr_pages;
nseg = pending_req->nr_segs;
indirect_grefs = INDIRECT_PAGES(nseg);
BUG_ON(indirect_grefs > BLKIF_MAX_INDIRECT_PAGES_PER_REQUEST);

Expand Down Expand Up @@ -1251,7 +1251,7 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif,
pending_req->id = req->u.rw.id;
pending_req->operation = req_operation;
pending_req->status = BLKIF_RSP_OKAY;
pending_req->nr_pages = nseg;
pending_req->nr_segs = nseg;

if (req->operation != BLKIF_OP_INDIRECT) {
preq.dev = req->u.rw.handle;
Expand Down Expand Up @@ -1372,7 +1372,7 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif,

fail_flush:
xen_blkbk_unmap(blkif, pending_req->segments,
pending_req->nr_pages);
pending_req->nr_segs);
fail_response:
/* Haven't submitted any bio's yet. */
make_response(blkif, req->u.rw.id, req_operation, BLKIF_RSP_ERROR);
Expand Down
2 changes: 1 addition & 1 deletion drivers/block/xen-blkback/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ struct grant_page {
struct pending_req {
struct xen_blkif *blkif;
u64 id;
int nr_pages;
int nr_segs;
atomic_t pendcnt;
unsigned short operation;
int status;
Expand Down

0 comments on commit 6684fa1

Please sign in to comment.