Skip to content

Commit

Permalink
USB: serial: keyspan_pda: drop redundant usb-serial pointer
Browse files Browse the repository at this point in the history
Drop the redundant struct usb_serial pointer from the driver port data.

Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
  • Loading branch information
Johan Hovold committed Nov 4, 2020
1 parent fbbf41f commit 66c32e4
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/usb/serial/keyspan_pda.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ static const struct usb_device_id id_table_fake[] = {
static int keyspan_pda_get_write_room(struct keyspan_pda_private *priv)
{
struct usb_serial_port *port = priv->port;
struct usb_serial *serial = priv->serial;
struct usb_serial *serial = port->serial;
u8 *room;
int rc;

Expand Down Expand Up @@ -114,7 +114,7 @@ static void keyspan_pda_request_unthrottle(struct work_struct *work)
struct keyspan_pda_private *priv =
container_of(work, struct keyspan_pda_private, unthrottle_work);
struct usb_serial_port *port = priv->port;
struct usb_serial *serial = priv->serial;
struct usb_serial *serial = port->serial;
unsigned long flags;
int result;

Expand Down Expand Up @@ -665,7 +665,6 @@ static int keyspan_pda_port_probe(struct usb_serial_port *port)
return -ENOMEM;

INIT_WORK(&priv->unthrottle_work, keyspan_pda_request_unthrottle);
priv->serial = port->serial;
priv->port = port;

usb_set_serial_port_data(port, priv);
Expand Down

0 comments on commit 66c32e4

Please sign in to comment.