Skip to content

Commit

Permalink
perf scripts python cs-etm: Add start and stop arguments
Browse files Browse the repository at this point in the history
Make it possible to only disassemble a range of timestamps or sample
indexes. This will be used by the test to limit the runtime, but it's
also useful for users.

Reviewed-by: Leo Yan <leo.yan@arm.com>
Signed-off-by: James Clark <james.clark@linaro.org>
Tested-by: Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>
Cc: Ben Gainey <ben.gainey@arm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Ruidong Tian <tianruidong@linux.alibaba.com>
Cc: Leo Yan <leo.yan@linux.dev>
Cc: Benjamin Gray <bgray@linux.ibm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: coresight@lists.linaro.org
Cc: John Garry <john.g.garry@oracle.com>
Cc: scclevenger@os.amperecomputing.com
Link: https://lore.kernel.org/r/20240916135743.1490403-7-james.clark@linaro.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
  • Loading branch information
James Clark authored and Namhyung Kim committed Sep 24, 2024
1 parent 8286cc5 commit 66dd3b5
Showing 1 changed file with 38 additions and 2 deletions.
40 changes: 38 additions & 2 deletions tools/perf/scripts/python/arm-cs-trace-disasm.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,20 +49,44 @@ def default_objdump():
return config if config else "objdump"

# Command line parsing.
def int_arg(v):
v = int(v)
if v < 0:
raise argparse.ArgumentTypeError("Argument must be a positive integer")
return v

args = argparse.ArgumentParser()
args.add_argument("-k", "--vmlinux",
help="Set path to vmlinux file. Omit to autodetect if running on same machine")
args.add_argument("-d", "--objdump", nargs="?", const=default_objdump(),
help="Show disassembly. Can also be used to change the objdump path"),
args.add_argument("-v", "--verbose", action="store_true", help="Enable debugging log")
args.add_argument("--start-time", type=int_arg, help="Monotonic clock time of sample to start from. "
"See 'time' field on samples in -v mode.")
args.add_argument("--stop-time", type=int_arg, help="Monotonic clock time of sample to stop at. "
"See 'time' field on samples in -v mode.")
args.add_argument("--start-sample", type=int_arg, help="Index of sample to start from. "
"See 'index' field on samples in -v mode.")
args.add_argument("--stop-sample", type=int_arg, help="Index of sample to stop at. "
"See 'index' field on samples in -v mode.")

options = args.parse_args()
if (options.start_time and options.stop_time and
options.start_time >= options.stop_time):
print("--start-time must less than --stop-time")
exit(2)
if (options.start_sample and options.stop_sample and
options.start_sample >= options.stop_sample):
print("--start-sample must less than --stop-sample")
exit(2)

# Initialize global dicts and regular expression
disasm_cache = dict()
cpu_data = dict()
disasm_re = re.compile(r"^\s*([0-9a-fA-F]+):")
disasm_func_re = re.compile(r"^\s*([0-9a-fA-F]+)\s.*:")
cache_size = 64*1024
sample_idx = -1

glb_source_file_name = None
glb_line_number = None
Expand Down Expand Up @@ -151,10 +175,10 @@ def print_disam(dso_fname, dso_start, start_addr, stop_addr):

def print_sample(sample):
print("Sample = { cpu: %04d addr: 0x%016x phys_addr: 0x%016x ip: 0x%016x " \
"pid: %d tid: %d period: %d time: %d }" % \
"pid: %d tid: %d period: %d time: %d index: %d}" % \
(sample['cpu'], sample['addr'], sample['phys_addr'], \
sample['ip'], sample['pid'], sample['tid'], \
sample['period'], sample['time']))
sample['period'], sample['time'], sample_idx))

def trace_begin():
print('ARM CoreSight Trace Data Assembler Dump')
Expand Down Expand Up @@ -216,6 +240,7 @@ def print_srccode(comm, param_dict, sample, symbol, dso):
def process_event(param_dict):
global cache_size
global options
global sample_idx

sample = param_dict["sample"]
comm = param_dict["comm"]
Expand All @@ -231,6 +256,17 @@ def process_event(param_dict):
ip = sample["ip"]
addr = sample["addr"]

sample_idx += 1

if (options.start_time and sample["time"] < options.start_time):
return
if (options.stop_time and sample["time"] > options.stop_time):
exit(0)
if (options.start_sample and sample_idx < options.start_sample):
return
if (options.stop_sample and sample_idx > options.stop_sample):
exit(0)

if (options.verbose == True):
print("Event type: %s" % name)
print_sample(sample)
Expand Down

0 comments on commit 66dd3b5

Please sign in to comment.