Skip to content

Commit

Permalink
regulator: of: Fix refcount leak bug in of_get_regulation_constraints()
Browse files Browse the repository at this point in the history
We should call the of_node_put() for the reference returned by
of_get_child_by_name() which has increased the refcount.

Fixes: 40e20d6 ("regulator: of: Add support for parsing regulator_state for suspend state")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220715111027.391032-1-windhl@126.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Liang He authored and Mark Brown committed Jul 15, 2022
1 parent 91de5eb commit 66efb66
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/regulator/of_regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,12 @@ static int of_get_regulation_constraints(struct device *dev,
}

suspend_np = of_get_child_by_name(np, regulator_states[i]);
if (!suspend_np || !suspend_state)
if (!suspend_np)
continue;
if (!suspend_state) {
of_node_put(suspend_np);
continue;
}

if (!of_property_read_u32(suspend_np, "regulator-mode",
&pval)) {
Expand Down

0 comments on commit 66efb66

Please sign in to comment.