Skip to content

Commit

Permalink
Staging: et131x: Kil the txmac type
Browse files Browse the repository at this point in the history
Only used for one trivial thing so turn that into something trivial instead

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Alan Cox authored and Greg Kroah-Hartman committed Mar 4, 2010
1 parent 69ea5fc commit 6720949
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 32 deletions.
39 changes: 12 additions & 27 deletions drivers/staging/et131x/et1310_address_map.h
Original file line number Diff line number Diff line change
Expand Up @@ -538,33 +538,18 @@ struct rxdma_regs { /* Location: */
/*
* structure for control reg in txmac address map
* located at address 0x3000
*
* bits
* 31-8: unused
* 7: cklseg_disable
* 6: ckbcnt_disable
* 5: cksegnum
* 4: async_disable
* 3: fc_disable
* 2: mcif_disable
* 1: mif_disable
* 0: txmac_en
*/
typedef union _TXMAC_CTL_t {
u32 value;
struct {
#ifdef _BIT_FIELDS_HTOL
u32 unused:24; /* bits 8-31 */
u32 cklseg_diable:1; /* bit 7 */
u32 ckbcnt_disable:1; /* bit 6 */
u32 cksegnum:1; /* bit 5 */
u32 async_disable:1; /* bit 4 */
u32 fc_disable:1; /* bit 3 */
u32 mcif_disable:1; /* bit 2 */
u32 mif_disable:1; /* bit 1 */
u32 txmac_en:1; /* bit 0 */
#else
u32 txmac_en:1; /* bit 0 */
u32 mif_disable:1; /* bit 1 mac interface */
u32 mcif_disable:1; /* bit 2 mem. contr. interface */
u32 fc_disable:1; /* bit 3 */
u32 async_disable:1; /* bit 4 */
u32 cksegnum:1; /* bit 5 */
u32 ckbcnt_disable:1; /* bit 6 */
u32 cklseg_diable:1; /* bit 7 */
u32 unused:24; /* bits 8-31 */
#endif
} bits;
} TXMAC_CTL_t, *PTXMAC_CTL_t;

/*
* structure for shadow pointer reg in txmac address map
Expand Down Expand Up @@ -695,7 +680,7 @@ typedef union _TXMAC_ERR_INT_t {
* Tx MAC Module of JAGCore Address Mapping
*/
typedef struct _TXMAC_t { /* Location: */
TXMAC_CTL_t ctl; /* 0x3000 */
u32 ctl; /* 0x3000 */
u32 shadow_ptr; /* 0x3004 */
TXMAC_ERR_CNT_t err_cnt; /* 0x3008 */
u32 max_fill; /* 0x300C */
Expand Down
9 changes: 4 additions & 5 deletions drivers/staging/et131x/et1310_mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@ void ConfigMACRegs2(struct et131x_adapter *etdev)
u32 cfg1;
u32 cfg2;
u32 ifctrl;
TXMAC_CTL_t ctl;
u32 ctl;

ctl.value = readl(&etdev->regs->txmac.ctl.value);
ctl = readl(&etdev->regs->txmac.ctl);
cfg1 = readl(&pMac->cfg1);
cfg2 = readl(&pMac->cfg2);
ifctrl = readl(&pMac->if_ctrl);
Expand Down Expand Up @@ -226,9 +226,8 @@ void ConfigMACRegs2(struct et131x_adapter *etdev)
}

/* Enable TXMAC */
ctl.bits.txmac_en = 0x1;
ctl.bits.fc_disable = 0x1;
writel(ctl.value, &etdev->regs->txmac.ctl.value);
ctl |= 0x05; /* TX mac enable, FC disable */
writel(ctl, &etdev->regs->txmac.ctl);

/* Ready to start the RXDMA/TXDMA engine */
if (etdev->Flags & fMP_ADAPTER_LOWER_POWER) {
Expand Down

0 comments on commit 6720949

Please sign in to comment.