Skip to content

Commit

Permalink
KVM: Discard zero mask with function kvm_dirty_ring_reset
Browse files Browse the repository at this point in the history
Function kvm_reset_dirty_gfn may be called with parameters cur_slot /
cur_offset / mask are all zero, it does not represent real dirty page.
It is not necessary to clear dirty page in this condition. Also return
value of macro __fls() is undefined if mask is zero which is called in
funciton kvm_reset_dirty_gfn(). Here just return.

Signed-off-by: Bibo Mao <maobibo@loongson.cn>
Message-ID: <20240613122803.1031511-1-maobibo@loongson.cn>
[Move the conditional inside kvm_reset_dirty_gfn; suggested by
 Sean Christopherson. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
Bibo Mao authored and Paolo Bonzini committed Jun 20, 2024
1 parent c31745d commit 676f819
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions virt/kvm/dirty_ring.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ static void kvm_reset_dirty_gfn(struct kvm *kvm, u32 slot, u64 offset, u64 mask)
struct kvm_memory_slot *memslot;
int as_id, id;

if (!mask)
return;

as_id = slot >> 16;
id = (u16)slot;

Expand Down

0 comments on commit 676f819

Please sign in to comment.