Skip to content

Commit

Permalink
MIPS: mm: Avoid HTW stop/start when dropping an inactive mm
Browse files Browse the repository at this point in the history
If drop_mmu_context() is called with an mm that is not currently active
on the local CPU then there's no need for us to stop & start a hardware
page table walker because it can't be fetching entries for the ASID
corresponding to the mm we're operating on.

Move the htw_stop() & htw_start() calls into the block which we run only
if the mm is currently active, in order to avoid the redundant work.

Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org
  • Loading branch information
Paul Burton committed Feb 4, 2019
1 parent 4739f7d commit 67741ba
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions arch/mips/include/asm/mmu_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -184,17 +184,18 @@ drop_mmu_context(struct mm_struct *mm)
unsigned int cpu;

local_irq_save(flags);
htw_stop();

cpu = smp_processor_id();
if (cpumask_test_cpu(cpu, mm_cpumask(mm))) {
htw_stop();
get_new_mmu_context(mm);
write_c0_entryhi(cpu_asid(cpu, mm));
htw_start();
} else {
/* will get a new context next time */
cpu_context(cpu, mm) = 0;
}
htw_start();

local_irq_restore(flags);
}

Expand Down

0 comments on commit 67741ba

Please sign in to comment.