Skip to content

Commit

Permalink
cifs: remove bogus call to cifs_cleanup_volume_info
Browse files Browse the repository at this point in the history
This call to cifs_cleanup_volume_info is clearly wrong. As soon as it's
called the following call to cifs_get_tcp_session will oops as the
volume_info pointer will then be NULL.

The caller of cifs_mount should clean up this data since it passed it
in. There's no need for us to call this here.

Regression introduced by commit 724d9f1.

Reported-by: Adam Williamson <awilliam@redhat.com>
Cc: Pavel Shilovsky <piastryyy@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
  • Loading branch information
Jeff Layton authored and Steve French committed Jul 6, 2011
1 parent de3796e commit 677d853
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fs/cifs/connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -3012,7 +3012,6 @@ cifs_mount(struct cifs_sb_info *cifs_sb, struct smb_vol *volume_info)
else if (pSesInfo)
cifs_put_smb_ses(pSesInfo);

cifs_cleanup_volume_info(&volume_info);
FreeXid(xid);
}
#endif
Expand Down

0 comments on commit 677d853

Please sign in to comment.