ovl: check snprintf return

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
mariux64 · Jul 27, 2017 · 6787341 · 6787341
1 parent 520eccd
commit 6787341
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
@@ -498,6 +498,9 @@ static int ovl_set_nlink_common(struct dentry *dentry,
 	len = snprintf(buf, sizeof(buf), format,
 		       (int) (inode->i_nlink - realinode->i_nlink));
 
+	if (WARN_ON(len >= sizeof(buf)))
+		return -EIO;
+
 	return ovl_do_setxattr(ovl_dentry_upper(dentry),
 			       OVL_XATTR_NLINK, buf, len, 0);
 }