Skip to content

Commit

Permalink
media: sun8i: Remove redundant platform_get_irq error message
Browse files Browse the repository at this point in the history
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  • Loading branch information
YueHaibing authored and Mauro Carvalho Chehab committed Feb 24, 2020
1 parent dc42cf7 commit 6821660
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
Original file line number Diff line number Diff line change
Expand Up @@ -814,11 +814,8 @@ static int deinterlace_probe(struct platform_device *pdev)
dev->dev = &pdev->dev;

irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
dev_err(dev->dev, "Failed to get IRQ\n");

if (irq <= 0)
return irq;
}

ret = devm_request_irq(dev->dev, irq, deinterlace_irq,
0, dev_name(dev->dev), dev);
Expand Down

0 comments on commit 6821660

Please sign in to comment.